Javier/dma to flash #18

Byte-Entropy · 2026-01-29T04:36:57Z

MX66L1G45GMI: Add DMA-backed SPI interface and refactor driver

Add MX66L1G45GMI_Interface.cpp: DMA-based SPI interface implementation
Update MX66L1G45GMI.cpp/.hpp to support abstracted interface and DMA
Integrate DMATransfer.hpp for efficient SPI transfers
Refactor driver to use function pointers for SPI, CS, and delay
Improve blocking/wait logic for DMA safety

This commit adds the initial, complete C++ driver for the NAU7802 sensor, placing it in the PeripheralDriversSubmodule. - Includes a reusable I2C_Wrapper to abstract STM32 HAL functions. - Implements core logic: init, reset, setGain, and readSensor. - Adds register definitions, example usage files, and a README.

Renamed Files: Changed I2C_Wrapper source and header files to i2c_wrapper (lowercase) for consistent naming conventions. Driver Update: Updated NAU7802 constructor to accept the I2C wrapper pointer and HAL_Delay function directly. Main Test Update: Modified main_read_test.cpp to implement the new initialization logic, set default gain to 1x, and added placeholders for future calibration. Cleanup: Removed the redundant ExampleUsage.cpp and the binary datasheet file (.pdf). Registers: Minor updates to register definitions in NAU7802_regs.hpp.

- Add MX66L1G45GMI_Interface.cpp: DMA-based SPI interface implementation - Update MX66L1G45GMI.cpp/.hpp to support abstracted interface and DMA - Integrate DMATransfer.hpp for efficient SPI transfers - Refactor driver to use function pointers for SPI, CS, and delay - Improve blocking/wait logic for DMA safety

Copilot

Pull request overview

Adds a DMA-backed SPI interface layer for the MX66L1G45GMI flash driver and refactors the core driver to use injected function pointers for IO (SPI read/write, chip-select, delay), along with new usage documentation.

Changes:

Added a new interface implementation (MX66L1G45GMI_Interface.cpp) intended to bridge the abstract driver to STM32 SPI/DMA.
Refactored the core driver (MX66L1G45GMI.cpp/.hpp) to use an injected MX66_Config (function pointers) instead of direct HAL calls.
Added a new driver README and updated gitignore rules related to DMA notes / Makefile.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
MX66L1G45GMI/README.md	Documents the layered architecture and initialization/usage guidance for the new injected/DMA approach.
MX66L1G45GMI/MX66L1G45GMI_Interface.cpp	Provides the concrete STM32 HAL + DMA-based implementation of the injected IO hooks.
MX66L1G45GMI/MX66L1G45GMI.cpp	Refactors the driver internals to call injected function pointers for SPI/CS/delay.
MX66L1G45GMI/Inc/MX66L1G45GMI.hpp	Introduces the `MX66_Config` struct and `MX66_Init()` API for dependency injection.
DMA/.gitignore	Ignores local DMA notes file(s).
.gitignore	Adds an ignore rule for `Makefile`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MX66L1G45GMI/MX66L1G45GMI.cpp

Copilot · 2026-01-31T17:43:33Z

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

+    // Use DMA Tool
+    DMAControl::Transfer(&hspi1, 0, nullptr, data, len);
+    // BLOCKING WAIT
+    while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);


Same issue as the write path: DMAControl::Transfer uses HAL_SPI_TransmitReceive_DMA(...) and will fail when txData is nullptr. For RX-only, the helper should call HAL_SPI_Receive_DMA (or provide a dummy TX buffer), and the returned status should be checked.

Suggested change

// Use DMA Tool

DMAControl::Transfer(&hspi1, 0, nullptr, data, len);

// BLOCKING WAIT

while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);

// For small reads, use polling to avoid DMA overhead

if (len <= 32) {

HAL_SPI_Receive(&hspi1, data, len, 100);

} else {

// Use DMA for larger reads

HAL_StatusTypeDef status = HAL_SPI_Receive_DMA(&hspi1, data);

if (status != HAL_OK) {

// DMA did not start; return without blocking indefinitely

return;

}

// BLOCKING WAIT

while (HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);

}

MX66L1G45GMI/README.md

MX66L1G45GMI/MX66L1G45GMI.cpp

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

MX66L1G45GMI/README.md

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

…ralDriversSubmodule into Javier/DmaToFlash

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

MX66L1G45GMI/README.md

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

AndreyDiDev · 2026-01-31T20:00:43Z

MX66L1G45GMI/README.md

+  MX_DMA_Init(); // <--- DMA MUST be initialized BEFORE SPI
+  MX_SPI1_Init();
+
+  // Inject the hardware dependencies into the driver


We want these to be inside the taks or driver, otherwise main gets crowded

its fro lines 87-97

AndreyDiDev · 2026-01-31T20:03:49Z

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp

+    HAL_GPIO_WritePin(SPI_FLASH_CS_GPIO_Port, SPI_FLASH_CS_Pin, high ? GPIO_PIN_SET : GPIO_PIN_RESET);
+}
+
+// Delay Implementation


have a note that this uses HAL delay, what is the point of this if we are renaming it only? And why is there two delays and explain why you used each one at that point and why

AndreyDiDev · 2026-01-31T20:17:11Z

MX66L1G45GMI/README.md

+
+// Delay Implementation
+void IMPL_Delay(uint32_t ms) {
+    // Change this line to switch between HAL_Delay, osDelay, vTaskDelay, etc


We dont want the programmer changing source code if they HAVE to make a change. This is fine since usually programmer wont have to switch between the delay functions. Do they? What is the point of using any other delay funcition?

Byte-Entropy added 10 commits October 25, 2025 11:14

Updated Readme to match previous Refactor

abdf0f2

WIP Task.cpp

1211490

d59885a

WIP: Implement Custom Delay

b26641e

Fix: Driverr compilation (obj) Success

839aa90

Initial Commit ADD DMA Transfer SPI & I2C

dabe891

Modif rm txt

147c7d7

Byte-Entropy requested a review from AndreyDiDev January 29, 2026 04:36

Byte-Entropy self-assigned this Jan 29, 2026

Byte-Entropy and others added 2 commits January 31, 2026 09:42

ADD Comprehensive README

6d49ad3

Merge branch 'master' into Javier/DmaToFlash

db2a532

Byte-Entropy requested a review from Copilot January 31, 2026 17:33

Copilot started reviewing on behalf of Byte-Entropy January 31, 2026 17:33 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

Byte-Entropy added 2 commits January 31, 2026 11:17

FIX problems under Git Comments

7c9a2b6

Merge branch 'Javier/DmaToFlash' of https://github.com/UCSOAR/Periphe…

41dcf52

…ralDriversSubmodule into Javier/DmaToFlash

Byte-Entropy requested a review from Copilot January 31, 2026 18:23

Copilot started reviewing on behalf of Byte-Entropy January 31, 2026 18:24 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp Outdated Show resolved Hide resolved

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp Outdated Show resolved Hide resolved

MX66L1G45GMI/README.md Outdated Show resolved Hide resolved

MX66L1G45GMI/MX66L1G45GMI_Interface.cpp Show resolved Hide resolved

Byte-Entropy added 2 commits January 31, 2026 12:02

FIX Interface cpp

fe7be3e

FIX MX cpp ADN INTERFACE

d09119e

AndreyDiDev reviewed Jan 31, 2026

View reviewed changes

-    // Use DMA Tool
-    DMAControl::Transfer(&hspi1, 0, nullptr, data, len);
-    // BLOCKING WAIT
-    while(HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);
+    // For small reads, use polling to avoid DMA overhead
+    if (len <= 32) {
+        HAL_SPI_Receive(&hspi1, data, len, 100);
+    } else {
+        // Use DMA for larger reads
+        HAL_StatusTypeDef status = HAL_SPI_Receive_DMA(&hspi1, data);
+        if (status != HAL_OK) {
+            // DMA did not start; return without blocking indefinitely
+            return;
+        }
+        // BLOCKING WAIT
+        while (HAL_SPI_GetState(&hspi1) != HAL_SPI_STATE_READY);
+    }

Javier/dma to flash #18

Are you sure you want to change the base?

Javier/dma to flash #18

Conversation

Byte-Entropy commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndreyDiDev Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

AndreyDiDev Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

AndreyDiDev Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

AndreyDiDev Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants